lint warnings & hardcoded text

2015-11-01 14:05:26 +01:00
parent 0c35ab6f10
commit 6d7427e50b
7 changed files with 21 additions and 15 deletions
--- a/app/src/main/java/net/headlezz/udacityproject1/favorites/FavoriteProviderHelper.java
+++ b/app/src/main/java/net/headlezz/udacityproject1/favorites/FavoriteProviderHelper.java
@@ -34,9 +34,10 @@ public class FavoriteProviderHelper {
        String selection = FavoriteColumns.TITLE + "=?";
        String[] selectionArgs = new String[]{movie.getTitle()};
        Cursor cursor = mResolver.query(FavoriteProvider.Favorites.FAVORITES_URI, projection, selection, selectionArgs, null);
-        if (cursor != null && cursor.getCount() > 0)
-            return true;
-        return false;
+        boolean isFavourite = (cursor != null && cursor.getCount() > 0)
+        if(cursor != null)
+            cursor.close();
+        return isFavourite;
    }

    public void addFavorite(Movie movie) {