diff --git a/app/src/main/java/net/headlezz/udacityproject1/favorites/FavoriteProviderHelper.java b/app/src/main/java/net/headlezz/udacityproject1/favorites/FavoriteProviderHelper.java index 8a8b5eb..ade6576 100644 --- a/app/src/main/java/net/headlezz/udacityproject1/favorites/FavoriteProviderHelper.java +++ b/app/src/main/java/net/headlezz/udacityproject1/favorites/FavoriteProviderHelper.java @@ -34,9 +34,10 @@ public class FavoriteProviderHelper { String selection = FavoriteColumns.TITLE + "=?"; String[] selectionArgs = new String[]{movie.getTitle()}; Cursor cursor = mResolver.query(FavoriteProvider.Favorites.FAVORITES_URI, projection, selection, selectionArgs, null); - if (cursor != null && cursor.getCount() > 0) - return true; - return false; + boolean isFavourite = (cursor != null && cursor.getCount() > 0) + if(cursor != null) + cursor.close(); + return isFavourite; } public void addFavorite(Movie movie) { diff --git a/app/src/main/res/layout-sw600dp-land/activity_main.xml b/app/src/main/res/layout-sw600dp-land/activity_main.xml index 848c2d5..007bb2e 100644 --- a/app/src/main/res/layout-sw600dp-land/activity_main.xml +++ b/app/src/main/res/layout-sw600dp-land/activity_main.xml @@ -1,5 +1,6 @@ + android:layout_height="match_parent" + android:baselineAligned="false"> diff --git a/app/src/main/res/layout/fragment_movie_details.xml b/app/src/main/res/layout/fragment_movie_details.xml index 85de97d..076a317 100644 --- a/app/src/main/res/layout/fragment_movie_details.xml +++ b/app/src/main/res/layout/fragment_movie_details.xml @@ -77,7 +77,7 @@ diff --git a/app/src/main/res/menu/movie_details_menu.xml b/app/src/main/res/menu/movie_details_menu.xml index 979805a..a5850c0 100644 --- a/app/src/main/res/menu/movie_details_menu.xml +++ b/app/src/main/res/menu/movie_details_menu.xml @@ -1,6 +1,6 @@ - - + + \ No newline at end of file diff --git a/app/src/main/res/menu/movie_list_menu.xml b/app/src/main/res/menu/movie_list_menu.xml index 5fbf231..e5b1738 100644 --- a/app/src/main/res/menu/movie_list_menu.xml +++ b/app/src/main/res/menu/movie_list_menu.xml @@ -1,7 +1,7 @@ - - - + + + diff --git a/app/src/main/res/values/dimens.xml b/app/src/main/res/values/dimens.xml index 5595f7e..7b0bc9c 100644 --- a/app/src/main/res/values/dimens.xml +++ b/app/src/main/res/values/dimens.xml @@ -1,7 +1,3 @@ - - 16dp - 16dp - 16dp false diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 1d99f08..3bd19e9 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -3,4 +3,11 @@ Settings Release: %1$s Rating: %1$s/10.0 + Share + Add/Remove Favorite + Popular movies + Highest av. rating + Favorites + No videos found. + Please select a movie