bump version

manifest.json

@@ -1,7 +1,7 @@
 {
   "id": "dataview-autocompletion",
   "name": "Dataview Autocompletion",
-  "version": "0.8.0",
+  "version": "0.8.2",
   "minAppVersion": "0.15.0",
   "description": "Adds autocompletion to Dataview metadata fields",
   "author": "Daniel Bauer",

package.json

@@ -1,6 +1,6 @@
 {
   "name": "obsidian-dataview-autocompletion",
-  "version": "0.8",
+  "version": "0.8.2",
   "description": "This is a plugin for Obsidian that provides autocompletion for Dataview metadata fields",
   "main": "main.js",
   "scripts": {

rollup.config.js

@@ -14,10 +14,6 @@ const createBaseConfig = (outdir) => ({
                     src: "manifest.json",
                     dest: outdir,
                 },
-                {
-                    src: "styles.css",
-                    dest: outdir,
-                },
             ],
         }),
     ),

src/DataviewSuggester.ts

@@ -159,6 +159,8 @@ export class DataviewSuggester extends EditorSuggest<String> {
             }
 
             const page = dataviewApi.page(file.path);
+            if (page === undefined) continue; // not a markdown file
+
             const fields = Object.keys(page)
                 .filter((k) => k !== "file")
                 .map((k) => [k, page[k]]);
@@ -218,6 +220,8 @@ export class DataviewSuggester extends EditorSuggest<String> {
             const updateCompositeValues = [];
 
             const page = getAPI(this.app).page(file.path);
+            if (page === undefined) return; // not a markdown file
+
             const fields = Object.keys(page)
                 .filter((k) => k !== "file")
                 .map((k) => [k, page[k]]);
@@ -297,13 +301,12 @@ export class DataviewSuggester extends EditorSuggest<String> {
             for (const value of this.suggestionsRefs.get(file.path)!) {
                 this.suggestionsRefCount.set(value, this.suggestionsRefCount.get(value)! - 1);
                 if (this.suggestionsRefCount.get(value) === 0) {
-                    console.debug("deleting value from suggestion index", value);
                     this.suggestionsList.splice(this.suggestionsList.indexOf(value), 1);
                 }
             }
             this.suggestionsRefs.delete(file.path);
         } else {
-            console.warn("Unknown update type:", type, file, oldPath);
+            console.debug("Unknown update type:", type, file, oldPath);
         }
     }
 }

src/main.ts

@@ -1,6 +1,6 @@
 import { App, Plugin, PluginSettingTab, Setting, TFile } from "obsidian";
 import { DataviewSuggester } from "./DataviewSuggester";
-import { getAPI } from "obsidian-dataview";
+import { getAPI, isPluginEnabled } from "obsidian-dataview";
 import { SettingsTab } from "./SettingsTab";
 
 interface DataviewAutocompleteSettings {
@@ -15,18 +15,19 @@ const DEFAULT_SETTINGS: DataviewAutocompleteSettings = {
 
 export default class DataviewAutocompletePlugin extends Plugin {
     settings: DataviewAutocompleteSettings;
-    suggester: DataviewSuggester | undefined;
+    suggester: DataviewSuggester;
 
     async onload() {
         await this.loadSettings();
         this.addSettingTab(new SettingsTab(this.app, this));
 
+        this.suggester = new DataviewSuggester(this, 10, true, true);
+        this.registerEditorSuggest(this.suggester);
+
         this.registerEvent(
             // @ts-ignore
             this.app.metadataCache.on("dataview:index-ready", () => {
-                if (this.suggester !== undefined) {
+                this.suggester.onDataviewIndexReady();
-                    this.suggester.onDataviewIndexReady();
-                }
             }),
         );
 
@@ -35,24 +36,14 @@ export default class DataviewAutocompletePlugin extends Plugin {
                 // @ts-ignore
                 "dataview:metadata-change",
                 (type: string, file: TFile, oldPath?: string) => {
-                    if (this.suggester !== undefined) {
+                    this.suggester.onDataviewMetadataChange(type, file, oldPath);
-                        this.suggester.onDataviewMetadataChange(type, file, oldPath);
-                    }
                 },
             ),
         );
 
-        this.app.workspace.onLayoutReady(() => {
+        if (isPluginEnabled(this.app) && getAPI(this.app)?.index.initialized) {
-            // @ts-ignore
+            this.suggester.onDataviewIndexReady();
-            if (!Object.keys(this.app.plugins.plugins).includes("dataview")) {
+        }
-                console.warn("Dataview plugin not installed. Dataview Autocompletion plugin will not work.");
-            } else {
-                // register suggester, requires dataview to be loaded first.
-                console.log("Registering dataview autocompletion suggester");
-                this.suggester = new DataviewSuggester(this, 10, true, true);
-                this.registerEditorSuggest(this.suggester);
-            }
-        });
     }
 
     onunload() {}

styles.css

@@ -1,8 +0,0 @@
-/*
-
-This CSS file will be included with your plugin, and
-available in the app when your plugin is enabled.
-
-If your plugin does not need CSS, delete this file.
-
-*/

test-vault/.obsidian/community-plugins.json

@@ -1,5 +1,6 @@
 [
   "sample-plugin",
   "dataview",
-  "obsidian-dataview-autocompletion"
+  "obsidian-dataview-autocompletion",
+  "dataview-autocompletion"
 ]

test-vault/not-a-markdown-file.json

@@ -0,0 +1 @@
+{"test": "this is a test file"}