From b79d363c9fdc36b74b70f268a5ea3fbeb320e539 Mon Sep 17 00:00:00 2001
From: daniel <github@dbauer.me>
Date: Mon, 23 Dec 2024 00:46:19 +0100
Subject: [PATCH] fix: inserted value should not use display value if display
 value is undefined

---
 src/DataviewSuggester.ts | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/src/DataviewSuggester.ts b/src/DataviewSuggester.ts
index 89126aa..a55fb41 100644
--- a/src/DataviewSuggester.ts
+++ b/src/DataviewSuggester.ts
@@ -122,14 +122,16 @@ export class DataviewSuggester extends EditorSuggest<String> {
         // If the value is a string, number or boolean, we can simply convert it to a string
         if (typeof value === "string" || typeof value === "number" || typeof value === "boolean") {
             stringValue = value.toString();
-        } else if (dataviewAPI.value.typeOf(value) === "link" && value.type === "file" && value.display !== undefined) {
-            // value.toString always adds a display value to wiki-style links.
-            // parse wiki-style links without display value manually here to prevent this from happening for [[filename]]
-            stringValue = `[[${value.path.split("/").pop().replace(".md", "")}]]`;
+        } else if (dataviewAPI.value.typeOf(value) === "link" && value.type === "file") {
+            // parse wiki-style links
+            if (value.display !== undefined) {
+                stringValue = `[[${value.path.split("/").pop().replace(".md", "")}|${value.display}]]`;
+            } else {
+                stringValue = `[[${value.path.split("/").pop().replace(".md", "")}]]`;
+            }
         } else {
             stringValue = dataviewAPI.value.toString(value);
         }
-
         return `${key}:: ${stringValue}`;
     }