linting

.flake8

@@ -0,0 +1,3 @@
+[flake8]
+max-line-length = 99
+exclude = .git, __pycache__, .pytest_cache, .venv, venv, build

django_signposting/middleware.py

@@ -36,4 +36,3 @@ class SignpostingMiddleware:
                 link_snippets[-1] += f' ; type="{signpost.type}"'
 
         response["Link"] = " , ".join(link_snippets)
-

django_signposting/utils.py

@@ -13,5 +13,5 @@ def add_signposts(response: HttpResponse, *args: Signpost):
         response._signposts = []
 
     for signpost in args:
-        if not signpost in response._signposts:
+        if signpost not in response._signposts:
-            response._signposts.append(signpost)
+            response._signposts.append(signpost)

example/example/urls.py

@@ -14,7 +14,6 @@ Including another URLconf
     1. Import the include() function: from django.urls import include, path
     2. Add a URL to urlpatterns:  path('blog/', include('blog.urls'))
 """
-from django.contrib import admin
 from django.urls import path
 
 from . import views

example/example/views.py

@@ -3,9 +3,10 @@ from django_signposting.utils import add_signposts
 
 from signposting import Signpost, LinkRel
 
+
 def my_view(request):
     response = HttpResponse("Hello, world!")
-    
+
     # Add signpostings as string
     add_signposts(
         response,
@@ -13,4 +14,4 @@ def my_view(request):
         Signpost(LinkRel.author, "https://orcid.org/0000-0001-9447-460X")
     )
 
-    return response
+    return response

pyproject.toml

@@ -28,4 +28,4 @@ dev = [
 [pytest]
 minversion = 6.0
 addopts = "-ra -q"
-testpaths = ["tests"]
+testpaths = ["tests"]

tests/conftest.py

@@ -1,4 +1,3 @@
-import pytest
 from django.conf import settings
 
 

tests/test_middleware.py

@@ -1,8 +1,8 @@
-from re import A
 from django.http import HttpResponse
 from django_signposting.middleware import SignpostingMiddleware
 from signposting import LinkRel, Signpost
 
+
 def test_middleware_no_signposting():
     response = HttpResponse()
     response.status_code = 200
@@ -74,4 +74,4 @@ def test_middleware_type_link():
 
     middleware = SignpostingMiddleware(lambda request: response)
     response = middleware(None)
-    assert response.headers["Link"] == '<http://schema.org/Dataset> ; rel="type"'
+    assert response.headers["Link"] == '<http://schema.org/Dataset> ; rel="type"'

tests/test_utils.py

@@ -5,7 +5,7 @@ from signposting import Signpost, LinkRel
 
 def test_add_signpost():
     response = HttpResponse()
-    add_signposts(response, Signpost(LinkRel.item,"http://example.com"))
+    add_signposts(response, Signpost(LinkRel.item, "http://example.com"))
 
     assert len(response._signposts) == 1
 
@@ -18,7 +18,6 @@ def test_add_multiple_signposts():
                   Signpost(LinkRel.author, "https://example3.com"),
                   )
 
-
     assert len(response._signposts) == 3
 
 
@@ -35,4 +34,4 @@ def test_add_signpost_duplicate():
     add_signposts(response, Signpost(LinkRel.item, "http://example.com"))
     add_signposts(response, Signpost(LinkRel.item, "http://example.com"))
 
-    assert len(response._signposts) == 1
+    assert len(response._signposts) == 1