mirror of
https://github.com/dnlbauer/cordra-mcp.git
synced 2026-09-10 21:55:30 +00:00
cc06e1eace
- Add find method to CordraClient for querying objects - Implement cordra://schemas resource for listing available type schemas - Add comprehensive unit tests for both client find method and server schema listing - Handle CordraPy response format with results array extraction - Support schema name extraction from returned objects
247 lines
9.9 KiB
Python
247 lines
9.9 KiB
Python
"""Unit tests for the MCP server."""
|
|
|
|
import json
|
|
from unittest.mock import AsyncMock, patch
|
|
|
|
import pytest
|
|
|
|
from mcp_cordra.client import CordraClientError, CordraNotFoundError, DigitalObject
|
|
from mcp_cordra.server import get_cordra_object
|
|
|
|
|
|
@pytest.fixture
|
|
def sample_digital_object():
|
|
"""Create a sample DigitalObject for testing."""
|
|
return DigitalObject(
|
|
id="people/john-doe-123",
|
|
type="Person",
|
|
content={
|
|
"name": "John Doe",
|
|
"birthday": "1990-05-15",
|
|
"email": "john.doe@example.com",
|
|
},
|
|
metadata={"created": "2023-01-01", "modified": "2023-06-15"},
|
|
acl={"read": ["public"], "write": ["admin"]},
|
|
payloads=[
|
|
{
|
|
"name": "profile_photo",
|
|
"filename": "john_doe_profile.jpg",
|
|
"size": 125440,
|
|
"mediaType": "image/jpeg"
|
|
}
|
|
]
|
|
)
|
|
|
|
|
|
class TestGetCordraObject:
|
|
"""Test the get_cordra_object resource handler."""
|
|
|
|
@patch('mcp_cordra.server.cordra_client')
|
|
async def test_get_object_success(self, mock_client, sample_digital_object):
|
|
"""Test successful object retrieval."""
|
|
mock_client.get_object = AsyncMock(return_value=sample_digital_object)
|
|
|
|
result = await get_cordra_object("people", "john-doe-123")
|
|
|
|
# Verify the result is valid JSON
|
|
parsed_result = json.loads(result)
|
|
assert parsed_result["id"] == "people/john-doe-123"
|
|
assert parsed_result["type"] == "Person"
|
|
assert parsed_result["content"]["name"] == "John Doe"
|
|
assert parsed_result["content"]["birthday"] == "1990-05-15"
|
|
assert parsed_result["metadata"]["created"] == "2023-01-01"
|
|
assert len(parsed_result["payloads"]) == 1
|
|
assert parsed_result["payloads"][0]["name"] == "profile_photo"
|
|
|
|
# Verify the client was called with the correct object ID
|
|
mock_client.get_object.assert_called_once_with("people/john-doe-123")
|
|
|
|
@patch('mcp_cordra.server.cordra_client')
|
|
async def test_get_object_not_found(self, mock_client):
|
|
"""Test object not found exception."""
|
|
mock_client.get_object = AsyncMock(
|
|
side_effect=CordraNotFoundError("Object not found: people/nonexistent")
|
|
)
|
|
|
|
with pytest.raises(RuntimeError) as exc_info:
|
|
await get_cordra_object("people", "nonexistent")
|
|
|
|
assert "Object not found: people/nonexistent" in str(exc_info.value)
|
|
mock_client.get_object.assert_called_once_with("people/nonexistent")
|
|
|
|
@patch('mcp_cordra.server.cordra_client')
|
|
async def test_get_object_client_error(self, mock_client):
|
|
"""Test general client error handling."""
|
|
mock_client.get_object = AsyncMock(
|
|
side_effect=CordraClientError("Connection failed")
|
|
)
|
|
|
|
with pytest.raises(RuntimeError) as exc_info:
|
|
await get_cordra_object("people", "john-doe-123")
|
|
|
|
assert "Failed to retrieve object people/john-doe-123" in str(exc_info.value)
|
|
assert "Connection failed" in str(exc_info.value)
|
|
mock_client.get_object.assert_called_once_with("people/john-doe-123")
|
|
|
|
@patch('mcp_cordra.server.cordra_client')
|
|
async def test_object_id_construction(self, mock_client, sample_digital_object):
|
|
"""Test that object ID is correctly constructed from prefix and suffix."""
|
|
mock_client.get_object = AsyncMock(return_value=sample_digital_object)
|
|
|
|
# Test various prefix/suffix combinations
|
|
test_cases = [
|
|
("people", "john-doe-123", "people/john-doe-123"),
|
|
("documents", "report-2023", "documents/report-2023"),
|
|
("items", "item_with_underscores", "items/item_with_underscores"),
|
|
]
|
|
|
|
for prefix, suffix, expected_id in test_cases:
|
|
await get_cordra_object(prefix, suffix)
|
|
mock_client.get_object.assert_called_with(expected_id)
|
|
|
|
@patch('mcp_cordra.server.cordra_client')
|
|
async def test_json_formatting(self, mock_client, sample_digital_object):
|
|
"""Test that the returned JSON is properly formatted."""
|
|
mock_client.get_object = AsyncMock(return_value=sample_digital_object)
|
|
|
|
result = await get_cordra_object("people", "john-doe-123")
|
|
|
|
# Verify it's valid JSON with proper indentation
|
|
parsed_result = json.loads(result)
|
|
assert isinstance(parsed_result, dict)
|
|
|
|
# Check that the result contains indentation (pretty-printed)
|
|
assert " " in result # Should have 2-space indentation
|
|
|
|
# Verify all expected fields are present
|
|
assert "id" in parsed_result
|
|
assert "type" in parsed_result
|
|
assert "content" in parsed_result
|
|
assert "metadata" in parsed_result
|
|
assert "acl" in parsed_result
|
|
assert "payloads" in parsed_result
|
|
|
|
@patch('mcp_cordra.server.cordra_client')
|
|
async def test_minimal_object(self, mock_client):
|
|
"""Test handling of object with minimal data."""
|
|
minimal_object = DigitalObject(
|
|
id="test/minimal",
|
|
type="",
|
|
content={"id": "test/minimal"},
|
|
metadata=None,
|
|
acl=None,
|
|
payloads=None
|
|
)
|
|
mock_client.get_object = AsyncMock(return_value=minimal_object)
|
|
|
|
result = await get_cordra_object("test", "minimal")
|
|
parsed_result = json.loads(result)
|
|
|
|
assert parsed_result["id"] == "test/minimal"
|
|
assert parsed_result["type"] == ""
|
|
assert parsed_result["content"]["id"] == "test/minimal"
|
|
assert parsed_result["metadata"] is None
|
|
assert parsed_result["acl"] is None
|
|
assert parsed_result["payloads"] is None
|
|
|
|
|
|
class TestListCordraSchemas:
|
|
"""Test the list_cordra_schemas resource handler."""
|
|
|
|
@patch('mcp_cordra.server.cordra_client')
|
|
async def test_list_schemas_success(self, mock_client):
|
|
"""Test successful schema listing."""
|
|
mock_schemas = [
|
|
{"name": "User", "identifier": "test/user-schema"},
|
|
{"name": "Project", "identifier": "test/project-schema"},
|
|
{"name": "Document", "identifier": "test/doc-schema"},
|
|
{"name": "CaptureEvent", "identifier": "test/capture-schema"}
|
|
]
|
|
mock_client.find = AsyncMock(return_value=mock_schemas)
|
|
|
|
from mcp_cordra.server import list_cordra_schemas
|
|
result = await list_cordra_schemas()
|
|
|
|
# Verify the result is valid JSON
|
|
parsed_result = json.loads(result)
|
|
assert "schemas" in parsed_result
|
|
assert "count" in parsed_result
|
|
assert parsed_result["count"] == 4
|
|
assert "User" in parsed_result["schemas"]
|
|
assert "Project" in parsed_result["schemas"]
|
|
assert "Document" in parsed_result["schemas"]
|
|
assert "CaptureEvent" in parsed_result["schemas"]
|
|
|
|
# Verify the client was called with correct query
|
|
mock_client.find.assert_called_once_with("type:Schema")
|
|
|
|
@patch('mcp_cordra.server.cordra_client')
|
|
async def test_list_schemas_empty(self, mock_client):
|
|
"""Test schema listing with no results."""
|
|
mock_client.find = AsyncMock(return_value=[])
|
|
|
|
from mcp_cordra.server import list_cordra_schemas
|
|
result = await list_cordra_schemas()
|
|
|
|
parsed_result = json.loads(result)
|
|
assert parsed_result["schemas"] == []
|
|
assert parsed_result["count"] == 0
|
|
|
|
mock_client.find.assert_called_once_with("type:Schema")
|
|
|
|
@patch('mcp_cordra.server.cordra_client')
|
|
async def test_list_schemas_missing_name_field(self, mock_client):
|
|
"""Test schema listing with objects missing name field."""
|
|
mock_schemas = [
|
|
{"name": "User", "identifier": "test/user-schema"},
|
|
{"identifier": "test/no-name-schema"}, # Missing name field
|
|
{"name": "Project", "identifier": "test/project-schema"},
|
|
{"other": "field"} # No name or identifier
|
|
]
|
|
mock_client.find = AsyncMock(return_value=mock_schemas)
|
|
|
|
from mcp_cordra.server import list_cordra_schemas
|
|
result = await list_cordra_schemas()
|
|
|
|
parsed_result = json.loads(result)
|
|
assert parsed_result["count"] == 2 # Only objects with name field
|
|
assert "User" in parsed_result["schemas"]
|
|
assert "Project" in parsed_result["schemas"]
|
|
assert len(parsed_result["schemas"]) == 2
|
|
|
|
@patch('mcp_cordra.server.cordra_client')
|
|
async def test_list_schemas_client_error(self, mock_client):
|
|
"""Test schema listing with client error."""
|
|
from mcp_cordra.client import CordraClientError
|
|
mock_client.find = AsyncMock(side_effect=CordraClientError("Search failed"))
|
|
|
|
from mcp_cordra.server import list_cordra_schemas
|
|
with pytest.raises(RuntimeError) as exc_info:
|
|
await list_cordra_schemas()
|
|
|
|
assert "Failed to list schemas" in str(exc_info.value)
|
|
assert "Search failed" in str(exc_info.value)
|
|
|
|
@patch('mcp_cordra.server.cordra_client')
|
|
async def test_list_schemas_json_format(self, mock_client):
|
|
"""Test that the returned JSON is properly formatted."""
|
|
mock_schemas = [
|
|
{"name": "TestSchema", "identifier": "test/schema"}
|
|
]
|
|
mock_client.find = AsyncMock(return_value=mock_schemas)
|
|
|
|
from mcp_cordra.server import list_cordra_schemas
|
|
result = await list_cordra_schemas()
|
|
|
|
# Verify it's valid JSON with proper indentation
|
|
parsed_result = json.loads(result)
|
|
assert isinstance(parsed_result, dict)
|
|
|
|
# Check that the result contains indentation (pretty-printed)
|
|
assert " " in result # Should have 2-space indentation
|
|
|
|
# Verify expected structure
|
|
assert "schemas" in parsed_result
|
|
assert "count" in parsed_result
|
|
assert isinstance(parsed_result["schemas"], list)
|
|
assert isinstance(parsed_result["count"], int) |