mirror of
https://github.com/dnlbauer/cordra-mcp.git
synced 2026-09-10 21:55:30 +00:00
feat: add design object resource for repository configuration access
Add new MCP resource cordra://design to retrieve Cordra's central design object containing repository configuration, type definitions, and system settings. - Add CordraClient.get_design() method using /api/objects/design endpoint - Add get_cordra_design() resource handler with proper MCP annotations - Include comprehensive error handling for authentication failures - Document administrative privilege requirements in descriptions - Add complete test coverage for both client and server functionality The design object provides AI systems access to understand the complete data model and configuration structure of a Cordra repository.
This commit is contained in:
@@ -5,6 +5,7 @@ from unittest.mock import patch
|
||||
import pytest
|
||||
|
||||
from cordra_mcp.client import (
|
||||
CordraAuthenticationError,
|
||||
CordraClient,
|
||||
CordraClientError,
|
||||
CordraNotFoundError,
|
||||
@@ -296,6 +297,71 @@ class TestCordraClient:
|
||||
timeout=30,
|
||||
)
|
||||
|
||||
@patch("cordra_mcp.client.requests.Session.get")
|
||||
async def test_get_design_success(self, mock_get, client):
|
||||
"""Test successful design object retrieval."""
|
||||
mock_design_data = {
|
||||
"type": "CordraDesign",
|
||||
"content": {
|
||||
"types": {"User": {}, "Project": {}},
|
||||
"workflows": {},
|
||||
"systemConfig": {"serverName": "test-cordra"}
|
||||
},
|
||||
"metadata": {"created": "2023-01-01", "modified": "2023-06-15"}
|
||||
}
|
||||
mock_response = mock_get.return_value
|
||||
mock_response.status_code = 200
|
||||
mock_response.json.return_value = mock_design_data
|
||||
mock_response.ok = True
|
||||
|
||||
result = await client.get_design()
|
||||
|
||||
assert isinstance(result, DigitalObject)
|
||||
assert result.id == "design"
|
||||
assert result.type == "CordraDesign"
|
||||
assert result.content["systemConfig"]["serverName"] == "test-cordra"
|
||||
|
||||
mock_get.assert_called_once_with(
|
||||
"https://test.example.com/api/objects/design",
|
||||
timeout=30,
|
||||
)
|
||||
|
||||
@patch("cordra_mcp.client.requests.Session.get")
|
||||
async def test_get_design_authentication_error(self, mock_get, client):
|
||||
"""Test design object retrieval with authentication error."""
|
||||
mock_response = mock_get.return_value
|
||||
mock_response.status_code = 403
|
||||
mock_response.ok = False
|
||||
|
||||
with pytest.raises(CordraAuthenticationError) as exc_info:
|
||||
await client.get_design()
|
||||
|
||||
assert "Authentication failed" in str(exc_info.value)
|
||||
|
||||
@patch("cordra_mcp.client.requests.Session.get")
|
||||
async def test_get_design_not_found(self, mock_get, client):
|
||||
"""Test design object retrieval with not found error."""
|
||||
mock_response = mock_get.return_value
|
||||
mock_response.status_code = 404
|
||||
mock_response.ok = False
|
||||
|
||||
with pytest.raises(CordraNotFoundError) as exc_info:
|
||||
await client.get_design()
|
||||
|
||||
assert "Resource not found" in str(exc_info.value)
|
||||
|
||||
@patch("cordra_mcp.client.requests.Session.get")
|
||||
async def test_get_design_request_error(self, mock_get, client):
|
||||
"""Test design object retrieval with request error."""
|
||||
from requests import RequestException
|
||||
|
||||
mock_get.side_effect = RequestException("Connection failed")
|
||||
|
||||
with pytest.raises(CordraClientError) as exc_info:
|
||||
await client.get_design()
|
||||
|
||||
assert "Failed to retrieve design object" in str(exc_info.value)
|
||||
|
||||
|
||||
class TestCordraConfig:
|
||||
"""Test the CordraConfig class."""
|
||||
|
||||
@@ -5,8 +5,13 @@ from unittest.mock import AsyncMock, patch
|
||||
|
||||
import pytest
|
||||
|
||||
from cordra_mcp.client import CordraClientError, CordraNotFoundError, DigitalObject
|
||||
from cordra_mcp.server import get_cordra_object, search_objects
|
||||
from cordra_mcp.client import (
|
||||
CordraAuthenticationError,
|
||||
CordraClientError,
|
||||
CordraNotFoundError,
|
||||
DigitalObject,
|
||||
)
|
||||
from cordra_mcp.server import get_cordra_design, get_cordra_object, search_objects
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
@@ -380,3 +385,101 @@ class TestSearchObjects:
|
||||
assert parsed_result[0]["id"] == "test/object"
|
||||
assert parsed_result[0]["type"] == "Test"
|
||||
assert parsed_result[0]["content"]["data"] == "value"
|
||||
|
||||
|
||||
class TestGetCordraDesign:
|
||||
"""Test the get_cordra_design resource handler."""
|
||||
|
||||
@patch('cordra_mcp.server.cordra_client')
|
||||
async def test_get_design_success(self, mock_client):
|
||||
"""Test successful design object retrieval."""
|
||||
mock_design = DigitalObject(
|
||||
id="design",
|
||||
type="CordraDesign",
|
||||
content={
|
||||
"types": {"User": {}, "Project": {}},
|
||||
"workflows": {},
|
||||
"systemConfig": {"serverName": "test-cordra"}
|
||||
},
|
||||
metadata={"created": "2023-01-01", "modified": "2023-06-15"}
|
||||
)
|
||||
mock_client.get_design = AsyncMock(return_value=mock_design)
|
||||
|
||||
result = await get_cordra_design()
|
||||
|
||||
# Verify the result is valid JSON
|
||||
parsed_result = json.loads(result)
|
||||
assert parsed_result["id"] == "design"
|
||||
assert parsed_result["type"] == "CordraDesign"
|
||||
assert parsed_result["content"]["systemConfig"]["serverName"] == "test-cordra"
|
||||
assert "types" in parsed_result["content"]
|
||||
assert "workflows" in parsed_result["content"]
|
||||
|
||||
# Verify the client was called
|
||||
mock_client.get_design.assert_called_once()
|
||||
|
||||
@patch('cordra_mcp.server.cordra_client')
|
||||
async def test_get_design_not_found(self, mock_client):
|
||||
"""Test design object not found exception."""
|
||||
mock_client.get_design = AsyncMock(
|
||||
side_effect=CordraNotFoundError("Design object not found")
|
||||
)
|
||||
|
||||
with pytest.raises(RuntimeError) as exc_info:
|
||||
await get_cordra_design()
|
||||
|
||||
assert "Design object not found" in str(exc_info.value)
|
||||
mock_client.get_design.assert_called_once()
|
||||
|
||||
@patch('cordra_mcp.server.cordra_client')
|
||||
async def test_get_design_authentication_error(self, mock_client):
|
||||
"""Test design object authentication error."""
|
||||
mock_client.get_design = AsyncMock(
|
||||
side_effect=CordraAuthenticationError("Authentication failed")
|
||||
)
|
||||
|
||||
with pytest.raises(RuntimeError) as exc_info:
|
||||
await get_cordra_design()
|
||||
|
||||
assert "Authentication failed" in str(exc_info.value)
|
||||
mock_client.get_design.assert_called_once()
|
||||
|
||||
@patch('cordra_mcp.server.cordra_client')
|
||||
async def test_get_design_client_error(self, mock_client):
|
||||
"""Test design object general client error."""
|
||||
mock_client.get_design = AsyncMock(
|
||||
side_effect=CordraClientError("Connection failed")
|
||||
)
|
||||
|
||||
with pytest.raises(RuntimeError) as exc_info:
|
||||
await get_cordra_design()
|
||||
|
||||
assert "Failed to retrieve design object" in str(exc_info.value)
|
||||
assert "Connection failed" in str(exc_info.value)
|
||||
mock_client.get_design.assert_called_once()
|
||||
|
||||
@patch('cordra_mcp.server.cordra_client')
|
||||
async def test_get_design_json_formatting(self, mock_client):
|
||||
"""Test that the design object is properly formatted as JSON."""
|
||||
mock_design = DigitalObject(
|
||||
id="design",
|
||||
type="CordraDesign",
|
||||
content={"data": "value"},
|
||||
metadata={"created": "2023-01-01"}
|
||||
)
|
||||
mock_client.get_design = AsyncMock(return_value=mock_design)
|
||||
|
||||
result = await get_cordra_design()
|
||||
|
||||
# Verify it's valid JSON with proper indentation
|
||||
parsed_result = json.loads(result)
|
||||
assert isinstance(parsed_result, dict)
|
||||
|
||||
# Check that the result contains indentation (pretty-printed)
|
||||
assert " " in result # Should have 2-space indentation
|
||||
|
||||
# Verify all expected fields are present
|
||||
assert "id" in parsed_result
|
||||
assert "type" in parsed_result
|
||||
assert "content" in parsed_result
|
||||
assert "metadata" in parsed_result
|
||||
|
||||
Reference in New Issue
Block a user