From 6edffb2944aec614232ddeaa7cf1f6bb57380128 Mon Sep 17 00:00:00 2001 From: danijoo Date: Sun, 1 Nov 2015 14:10:08 +0100 Subject: [PATCH] fixed crash for non tablets --- .../java/net/headlezz/udacityproject1/MainActivity.java | 8 ++------ .../udacityproject1/favorites/FavoriteProviderHelper.java | 2 +- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/app/src/main/java/net/headlezz/udacityproject1/MainActivity.java b/app/src/main/java/net/headlezz/udacityproject1/MainActivity.java index e444ab0..7616410 100644 --- a/app/src/main/java/net/headlezz/udacityproject1/MainActivity.java +++ b/app/src/main/java/net/headlezz/udacityproject1/MainActivity.java @@ -5,26 +5,22 @@ import android.support.v4.app.FragmentManager; import android.support.v7.app.AppCompatActivity; import android.support.v7.widget.Toolbar; import android.view.View; -import android.widget.TextView; import net.headlezz.udacityproject1.movielist.MovieListFragment; import net.headlezz.udacityproject1.tmdbapi.Movie; -import butterknife.Bind; -import butterknife.ButterKnife; - /** * Main activity is mainly for handling fragment transactions */ public class MainActivity extends AppCompatActivity implements MovieNavigation, FragmentManager.OnBackStackChangedListener { - @Bind(R.id.main_details_placeHolderText) TextView detailsPlaceholderView; + View detailsPlaceholderView; @Override protected void onCreate(Bundle savedInstanceState) { super.onCreate(savedInstanceState); setContentView(R.layout.activity_main); - ButterKnife.bind(this); + detailsPlaceholderView = findViewById(R.id.main_details_placeHolderText); Toolbar toolbar = (Toolbar) findViewById(R.id.toolbar); setSupportActionBar(toolbar); setTitle(getString(R.string.app_name)); diff --git a/app/src/main/java/net/headlezz/udacityproject1/favorites/FavoriteProviderHelper.java b/app/src/main/java/net/headlezz/udacityproject1/favorites/FavoriteProviderHelper.java index ade6576..2d6cd8a 100644 --- a/app/src/main/java/net/headlezz/udacityproject1/favorites/FavoriteProviderHelper.java +++ b/app/src/main/java/net/headlezz/udacityproject1/favorites/FavoriteProviderHelper.java @@ -34,7 +34,7 @@ public class FavoriteProviderHelper { String selection = FavoriteColumns.TITLE + "=?"; String[] selectionArgs = new String[]{movie.getTitle()}; Cursor cursor = mResolver.query(FavoriteProvider.Favorites.FAVORITES_URI, projection, selection, selectionArgs, null); - boolean isFavourite = (cursor != null && cursor.getCount() > 0) + boolean isFavourite = (cursor != null && cursor.getCount() > 0); if(cursor != null) cursor.close(); return isFavourite;