diff --git a/app/src/main/java/net/headlezz/udacityproject1/MovieListFragment.java b/app/src/main/java/net/headlezz/udacityproject1/MovieListFragment.java index f1eb811..9ba75e7 100644 --- a/app/src/main/java/net/headlezz/udacityproject1/MovieListFragment.java +++ b/app/src/main/java/net/headlezz/udacityproject1/MovieListFragment.java @@ -1,6 +1,7 @@ package net.headlezz.udacityproject1; import android.content.Context; +import android.content.res.Configuration; import android.os.Bundle; import android.support.v4.app.Fragment; import android.support.v7.widget.GridLayoutManager; @@ -36,8 +37,8 @@ public class MovieListFragment extends Fragment { /** * The number of columns our movie grid shows */ - private static final int NUM_COLUMNS = 3; // TODO adjust colum count for landscape - + private static final int NUM_COLUMNS_PORTRAIT = 3; + private static final int NUM_COLUMNS_LAND = 5; /** * The currently selected sorting order of the list * @see TMDBApi @@ -68,7 +69,20 @@ public class MovieListFragment extends Fragment { @Override public void onActivityCreated(Bundle savedInstanceState) { super.onActivityCreated(savedInstanceState); - mMovieGridView.setLayoutManager(new GridLayoutManager(getActivity(), NUM_COLUMNS)); + mMovieGridView.setLayoutManager(new GridLayoutManager(getActivity(), getNumColumns())); + } + + /** + * @return the number of columns the app should show + * The result depends on screen orientation + */ + private int getNumColumns() { + int orientation = getActivity().getResources().getConfiguration().orientation; + if(orientation == Configuration.ORIENTATION_LANDSCAPE) + return NUM_COLUMNS_LAND; + else + return NUM_COLUMNS_PORTRAIT; + } @Override diff --git a/app/src/main/java/net/headlezz/udacityproject1/tmdbapi/TMDBApi.java b/app/src/main/java/net/headlezz/udacityproject1/tmdbapi/TMDBApi.java index 4ffb010..7e3b79a 100644 --- a/app/src/main/java/net/headlezz/udacityproject1/tmdbapi/TMDBApi.java +++ b/app/src/main/java/net/headlezz/udacityproject1/tmdbapi/TMDBApi.java @@ -20,7 +20,7 @@ import retrofit.http.Query; public class TMDBApi { private static final String BASE_URL = "http://api.themoviedb.org/3/"; - private static final String IMAGE_BASE_URL = "http://image.tmdb.org/t/p/w185"; // TODO select size depending on device screen ratios + private static final String IMAGE_BASE_URL = "http://image.tmdb.org/t/p/w185"; /** * These are the possible sorting orders diff --git a/app/src/main/res/layout/activity_main.xml b/app/src/main/res/layout/activity_main.xml index f918c61..3249599 100644 --- a/app/src/main/res/layout/activity_main.xml +++ b/app/src/main/res/layout/activity_main.xml @@ -10,7 +10,7 @@ + android:background="?attr/colorPrimary"/> + android:layout_alignParentEnd="true" /> + android:layout_alignStart="@+id/movie_details_tvReleaseDate" + android:layout_marginTop="39dp" /> > - - diff --git a/app/src/main/res/values/styles.xml b/app/src/main/res/values/styles.xml index 44f664f..91580a0 100644 --- a/app/src/main/res/values/styles.xml +++ b/app/src/main/res/values/styles.xml @@ -11,7 +11,5 @@ false true -