From c8c79700b316d48f830c004ab2ccc3f6b1f64584 Mon Sep 17 00:00:00 2001
From: danijoo <danijob88@googlemail.com>
Date: Sat, 2 Jan 2016 22:12:09 +0100
Subject: [PATCH] dividers

---
 .../NotificationListFragment.java             |   1 -
 .../res/layout/notification_list_item.xml     | 136 ++++++++++--------
 2 files changed, 74 insertions(+), 63 deletions(-)

diff --git a/app/src/main/java/net/headlezz/notificationlogger/notificationlist/NotificationListFragment.java b/app/src/main/java/net/headlezz/notificationlogger/notificationlist/NotificationListFragment.java
index edf4c5b..c18aaab 100644
--- a/app/src/main/java/net/headlezz/notificationlogger/notificationlist/NotificationListFragment.java
+++ b/app/src/main/java/net/headlezz/notificationlogger/notificationlist/NotificationListFragment.java
@@ -34,7 +34,6 @@ public class NotificationListFragment extends Fragment implements LoaderManager.
     private NotificationListAdapter mAdapter;
 
     // TODO reload list if new notification arrives
-    // TODO notification list divider
 
     @Nullable
     @Override
diff --git a/app/src/main/res/layout/notification_list_item.xml b/app/src/main/res/layout/notification_list_item.xml
index 884e617..474e9c9 100644
--- a/app/src/main/res/layout/notification_list_item.xml
+++ b/app/src/main/res/layout/notification_list_item.xml
@@ -1,77 +1,89 @@
 <?xml version="1.0" encoding="utf-8"?>
-<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
+<FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:tools="http://schemas.android.com/tools"
     android:layout_width="match_parent"
-    android:layout_height="match_parent"
-    android:orientation="horizontal"
-    android:padding="8dp"
-    android:foreground="?attr/selectableItemBackground">
+    android:layout_height="wrap_content">
 
-    <ImageView
-        android:layout_marginEnd="16dp"
-        android:id="@+id/notification_item_appIcon"
-        android:layout_width="64dp"
-        android:layout_height="64dp"
-        tools:src="@mipmap/ic_launcher" />
-
-    <RelativeLayout
+    <LinearLayout
         android:layout_width="match_parent"
-        android:layout_height="wrap_content"
-        android:layout_gravity="center_horizontal"
-        android:orientation="vertical">
+        android:layout_height="match_parent"
+        android:foreground="?attr/selectableItemBackground"
+        android:orientation="horizontal"
+        android:padding="8dp">
 
         <ImageView
-            android:contentDescription="@string/notification_small_icon_cd"
-            android:id="@+id/notification_item_smallIcon"
-            android:layout_width="24dp"
-            android:layout_height="24dp"
-            tools:src="@drawable/ic_sd_card" />
+            android:id="@+id/notification_item_appIcon"
+            android:layout_width="64dp"
+            android:layout_height="64dp"
+            android:layout_marginEnd="16dp"
+            tools:src="@mipmap/ic_launcher" />
 
-        <TextView
-            android:id="@+id/notification_item_appName"
-            android:textAppearance="@style/TextAppearance.AppCompat.Title"
+        <RelativeLayout
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
-            android:layout_alignParentTop="true"
-            android:lines="1"
-            tools:text="A really long app name thats ellipsed"
-            android:ellipsize="end"
-            android:layout_toEndOf="@+id/notification_item_smallIcon"
-            android:layout_toStartOf="@+id/notification_item_date"/>
+            android:layout_gravity="center_horizontal"
+            android:orientation="vertical">
 
-        <TextView
-            android:lines="1"
-            android:ellipsize="end"
-            android:layout_marginTop="4dp"
-            android:id="@+id/notification_item_title"
-            android:textAppearance="@style/TextAppearance.AppCompat.Body2"
-            android:layout_width="wrap_content"
-            android:layout_height="wrap_content"
-            android:layout_alignParentStart="true"
-            android:layout_below="@+id/notification_item_appName"
-            tools:text="Notification title" />
+            <ImageView
+                android:id="@+id/notification_item_smallIcon"
+                android:layout_width="24dp"
+                android:layout_height="24dp"
+                android:contentDescription="@string/notification_small_icon_cd"
+                tools:src="@drawable/ic_sd_card" />
 
-        <TextView
-            android:layout_marginStart="4dp"
-            android:id="@+id/notification_item_date"
-            android:layout_width="wrap_content"
-            android:layout_height="wrap_content"
-            android:layout_alignParentEnd="true"
-            android:layout_alignParentTop="true"
-            tools:text="16 hours ago"
-            android:textAppearance="@style/TextAppearance.AppCompat.Caption" />
+            <TextView
+                android:id="@+id/notification_item_appName"
+                android:layout_width="match_parent"
+                android:layout_height="wrap_content"
+                android:layout_alignParentTop="true"
+                android:layout_toEndOf="@+id/notification_item_smallIcon"
+                android:layout_toStartOf="@+id/notification_item_date"
+                android:ellipsize="end"
+                android:lines="1"
+                android:textAppearance="@style/TextAppearance.AppCompat.Title"
+                tools:text="A really long app name thats ellipsed" />
 
-        <TextView
-            android:lines="3"
-            android:ellipsize="end"
-            android:id="@+id/notification_item_message"
-            android:textAppearance="@style/TextAppearance.AppCompat.Body1"
-            android:layout_width="wrap_content"
-            android:layout_height="wrap_content"
-            android:layout_alignParentStart="true"
-            android:layout_below="@+id/notification_item_title"
-            tools:text="Some messages wit lots of text and \nTwo lines" />
-    </RelativeLayout>
+            <TextView
+                android:id="@+id/notification_item_title"
+                android:layout_width="wrap_content"
+                android:layout_height="wrap_content"
+                android:layout_alignParentStart="true"
+                android:layout_below="@+id/notification_item_appName"
+                android:layout_marginTop="4dp"
+                android:ellipsize="end"
+                android:lines="1"
+                android:textAppearance="@style/TextAppearance.AppCompat.Body2"
+                tools:text="Notification title" />
+
+            <TextView
+                android:id="@+id/notification_item_date"
+                android:layout_width="wrap_content"
+                android:layout_height="wrap_content"
+                android:layout_alignParentEnd="true"
+                android:layout_alignParentTop="true"
+                android:layout_marginStart="4dp"
+                android:textAppearance="@style/TextAppearance.AppCompat.Caption"
+                tools:text="16 hours ago" />
+
+            <TextView
+                android:id="@+id/notification_item_message"
+                android:layout_width="wrap_content"
+                android:layout_height="wrap_content"
+                android:layout_alignParentStart="true"
+                android:layout_below="@+id/notification_item_title"
+                android:ellipsize="end"
+                android:maxLines="3"
+                android:textAppearance="@style/TextAppearance.AppCompat.Body1"
+                tools:text="Some messages wit lots of text and \nTwo lines" />
+        </RelativeLayout>
 
 
-</LinearLayout>
\ No newline at end of file
+    </LinearLayout>
+
+    <View
+        android:layout_gravity="bottom"
+        android:background="?attr/colorControlHighlight"
+        android:layout_height="1dp"
+        android:layout_width="match_parent"
+        />
+</FrameLayout>
\ No newline at end of file